----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41106/#review109428 -----------------------------------------------------------
Thanks, Tao! One issue in the comment. samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala (line 54) <https://reviews.apache.org/r/41106/#comment168948> It would be better to use JobConfig.getContainerCount() instead of repeating the code here. The following line does the trick for you to use config object as JobConfig object: import org.apache.samza.config.JobConfig.Config2Job - Yi Pan (Data Infrastructure) On Dec. 8, 2015, 10:49 p.m., Tao Feng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41106/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 10:49 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > throws runtime exception if user sets yarn.container.count or > job.container.count greater than 1 for ProcessJobFactory > > > Diffs > ----- > > > samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala > 0792a59cb7b042220c8dbfc0713c5ef42e93ab25 > > Diff: https://reviews.apache.org/r/41106/diff/ > > > Testing > ------- > > 1. ./gradlew clean build > 2. ./gradlew checkstyleMain checkstyleTest > 3. manual test open source hello samza and verify that by giving > yarn.container.count or job.container.count with value greater than 1 for > ProcessJobFactory, the test will throw the desired exception. > > > Thanks, > > Tao Feng > >
