----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43053/#review117242 -----------------------------------------------------------
Fix it, then Ship it! LGTM. One minor comment below. samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala (line 162) <https://reviews.apache.org/r/43053/#comment178367> nitpick: the var name of "msg1" seems not very well chosen. Shall we do warn(msg + "...") instead? - Xinyu Liu On Feb. 1, 2016, 6:25 p.m., Boris Shkolnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43053/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 6:25 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > We have a validation code that verifies that checkpoint topic has the right > number of partitions (1). > But, in some environments, it is difficult to repair or delete the invalid > topic. > This config will allow to by pass this validation (it will issue a warning > only) and to continue with a checkpoint topic with an incorrect number of > partitions. > The checkpoints are written into partion 0. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala > 1a8adae4d30fa198c90e8c177c7f17269c5953cd > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > 787de1f62479a098bf251f072fca03bbf92f7c6d > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala > 7db894091284794b7f5fac164eb55b5d78184a36 > > samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala > c6b1fe4bf3c3601502e014d582d86f8ea0850b20 > samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala > f4311d1cda7c66c66544c5a3ac94a17cae62863a > > samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala > af4051b28df5eeaeaee527a24907a8e66441f743 > > Diff: https://reviews.apache.org/r/43053/diff/ > > > Testing > ------- > > > Thanks, > > Boris Shkolnik > >
