+1. Calcite uses pull requests for contributions from non-committers and according to my experience with Calcite, pull requests are easier than the current approach we follow in Samza.
Milinda On Thu, Feb 18, 2016 at 9:09 PM, Roger Hoover <roger.hoo...@gmail.com> wrote: > +1 - Thanks for bringing this up, Yi. I've done it both ways and feel > pull requests are much easier. > > Sent from my iPhone > > > On Feb 18, 2016, at 4:25 PM, Navina Ramesh <nram...@linkedin.com.INVALID> > wrote: > > > > +1 > > > > Haven't tried any contribution with pull requests. But sounds simpler > than > > attaching the patch to JIRA. > > > > Navina > > > >> On Thu, Feb 18, 2016 at 4:01 PM, Jacob Maes <jacob.m...@gmail.com> > wrote: > >> > >> +1 > >> > >> As a relatively new contributor to Samza, I've certainly felt the > current > >> process was overly-complicated. > >> > >>> On Thu, Feb 18, 2016 at 3:53 PM, Yi Pan <nickpa...@gmail.com> wrote: > >>> > >>> Hi, all, > >>> > >>> I want to start the discussion on our code review/commit process. > >>> > >>> I felt that our code review and check-in process is a little bit > >>> cumbersome: > >>> - developers need to create RBs and attach diff to JIRA > >>> - committers need to review RBs, dowload diff and apply, then push. > >>> > >>> It would be much lighter if we take the pull request only approach, as > >>> Kafka already converted to: > >>> - for the developers, the only thing needed is to open a pull request. > >>> - for committers, review and apply patch is from the same PR and merge > >> can > >>> be done directly on remote git repo. > >>> > >>> Of course, there might be some hookup scripts that we will need to link > >>> JIRA w/ pull request in github, which Kafka already does. Any comments > >> and > >>> feedbacks are welcome! > >>> > >>> Thanks! > >>> > >>> -Yi > > > > > > > > -- > > Navina R. > -- Milinda Pathirage PhD Student | Research Assistant School of Informatics and Computing | Data to Insight Center Indiana University twitter: milindalakmal skype: milinda.pathirage blog: http://milinda.pathirage.org
