> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote: > > samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java, > > line 96 > > <https://reviews.apache.org/r/45912/diff/1/?file=1331874#file1331874line96> > > > > Maybe, I'm missing context on this change. What is the bug that this > > change addresses? > > > > It would be really helpful if you could please explain the problem > > (maybe in a JIRA), and how this fixes it.
Jagadish, I believe this is related to SAMZA-933. - Navina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45912/#review127723 ----------------------------------------------------------- On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45912/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 12:02 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, > otherwise it wouldn't discover the basic types like HashMap Entry > > > Diffs > ----- > > > samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java > 717b5dcad2aa22540deb08962bf2833e7dc5baa5 > > Diff: https://reviews.apache.org/r/45912/diff/ > > > Testing > ------- > > > Thanks, > > Yuanchi Ning > >