----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46732/#review131526 -----------------------------------------------------------
Can you please clarify in the descriptions - what was the issue and the fix. - Boris Shkolnik On April 29, 2016, 11:13 a.m., Alex Buck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46732/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 11:13 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > fix issue with json deserialisation in YarnUtil > > > Diffs > ----- > > checkstyle/import-control.xml c15b8e74de8e5aac5ac83278c52ab3dba1630e50 > > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java > 376c549ededaa04401513752b510a4e6c3a6e386 > > samza-autoscaling/src/test/java/org/apache/samza/autoscaling/utils/YarnUtilTest.java > PRE-CREATION > samza-autoscaling/src/test/resources/exampleResourceManagerOutput.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/46732/diff/ > > > Testing > ------- > > Very open to any feedback especially as it's my first review request for > Samza. Thanks > > https://issues.apache.org/jira/browse/SAMZA-930 > > > Thanks, > > Alex Buck > >