-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47073/#review132090
-----------------------------------------------------------


Ship it!




+1 lgtm!

- Navina Ramesh


On May 6, 2016, 5:30 p.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47073/
> -----------------------------------------------------------
> 
> (Updated May 6, 2016, 5:30 p.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina 
> Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-946
>     https://issues.apache.org/jira/browse/SAMZA-946
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-946 - ConcurrentModificationException in TaskAssignmentManager
>     * Copy the map before returning it
>     * A little cleanup in TaskAssignment manager
>     * Also fixing a javadoc issue introduced in SAMZA-944, oops
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/config/DefaultChooserConfig.java 
> d242d1476841caf5c82ddf19c51c992a36d9591b 
>   
> samza-core/src/main/java/org/apache/samza/container/grouper/task/TaskAssignmentManager.java
>  ec5cf3da4d1967cf586cdf074262a1f42f1efb75 
>   
> samza-core/src/test/java/org/apache/samza/container/grouper/task/TestTaskAssignmentManager.java
>  7f834941862e24649e00d804627f87cf733b7eb3 
> 
> Diff: https://reviews.apache.org/r/47073/diff/
> 
> 
> Testing
> -------
> 
> Added a new test which reproduces the exception and ran all tests.
> 
> 
> Thanks,
> 
> Jake Maes
> 
>

Reply via email to