----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46287/#review132481 -----------------------------------------------------------
Ship it! +1. lgtm! - Yi Pan (Data Infrastructure) On April 15, 2016, 11:17 p.m., Jon Bringhurst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46287/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 11:17 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-936 > https://issues.apache.org/jira/browse/SAMZA-936 > > > Repository: samza > > > Description > ------- > > Add a simple double serde. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/serializers/DoubleSerde.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/serializers/TestDoubleSerde.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/46287/diff/ > > > Testing > ------- > > A simple unit test was added. > > > Thanks, > > Jon Bringhurst > >