----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47251/#review132730 -----------------------------------------------------------
Ship it! Thanks for getting the fix in! lgtm - Jagadish - Jagadish Venkatraman On May 11, 2016, 6:53 p.m., Jake Maes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47251/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 6:53 p.m.) > > > Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina > Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure). > > > Bugs: SAMZA-852 > https://issues.apache.org/jira/browse/SAMZA-852 > > > Repository: samza > > > Description > ------- > > SAMZA-852 - Better logging when system can not be created Always log the > exception when we cant instantiate a producer or consumer > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 5462208c08cddbfd30d886daffa8c02c82447059 > > Diff: https://reviews.apache.org/r/47251/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Jake Maes > >
