-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47620/
-----------------------------------------------------------
(Updated May 20, 2016, 12:04 a.m.)
Review request for samza, Boris Shkolnik, Chris Pettitt, Jake Maes, Navina
Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
Summary (updated)
-----------------
SAMZA-951 - Improve event loop timing metrics
Bugs: SAMZA-951
https://issues.apache.org/jira/browse/SAMZA-951
Repository: samza
Description
-------
SAMZA-951 - Improve event loop timing metrics
* Exclude choose-ns from the active time, thereby removing the associated
poll() waiting from the event-loop-utilization metric
* Add poll-ns and deserialization-ns metrics to SystemConsumers to help users
understand the time spent during choose. To do this, I needed to extend
TimerUtils, which required a nano clock and an alternate constructor.
* Fix some small issues with naming conventions, etc
Diffs
-----
samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala
6916c5c71e479d43a7435fa4987565d93ed437ac
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
9e6641c3628290dc05e1eb5537e86bff9d37f92c
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
32fc771ed31fc84516472fb027902506574f53ab
samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala
e7f012f5b1a15254078aa85310082c91ac8b56e0
samza-core/src/test/scala/org/apache/samza/container/TestRunLoop.scala
ad3744711cc5ef17b5d3a45eb7b567956d77453a
Diff: https://reviews.apache.org/r/47620/diff/
Testing (updated)
-------
./gradlew build
Deployed in a test job.
See the before/after screenshots. Note that they're zoomed in on time and they
don't have the same y-axis value range. Both screenshots were with the same job
which has way more containers than it needs, and is mostly idle.
File Attachments
----------------
UtilizationBefore
https://reviews.apache.org/media/uploaded/files/2016/05/19/55101a6d-8c3d-430a-b415-78108d92d4bc__Utilization_Before.png
UtilizationAfter
https://reviews.apache.org/media/uploaded/files/2016/05/19/de13bf3d-63e2-4ac6-82ce-60bc5cb6a973__Utilization_After.png
Thanks,
Jake Maes
