> On June 29, 2016, 2:16 a.m., Navina Ramesh wrote: > > Robert, > > Are you expecting more changes for 0.10.0 upgrade? Just checking on your > > progress. Thanks!
Yes, this just updates the client version but does not use the 0.9+ producer and consumer. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49212/#review139920 ----------------------------------------------------------- On June 24, 2016, 7:45 p.m., Robert Crim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49212/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 7:45 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > This is a WIP for updating the the kafka client libraries to 0.10+. So far, > I've updated the dependency and simply worked to get all existing tests > passing. The next steps are to further test/verify backwards compatiblity > with older brokers and moving the current `KafkaSystemFactory`, etc, to > `OldKafkaSystemFactory` and implementing the new clients. > > > Diffs > ----- > > build.gradle ba4a9d1 > gradle/dependency-versions.gradle 47c71bf > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala > ea10cae > > samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManagerFactory.scala > 4e97376 > > samza-kafka/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala > 78467bf > > samza-kafka/src/main/scala/org/apache/samza/migration/KafkaCheckpointMigration.scala > 5e8cc65 > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemAdmin.scala > ba8de5c > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala > b373753 > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala > b574176 > samza-kafka/src/main/scala/org/apache/samza/util/KafkaUtil.scala a25ba62 > > samza-kafka/src/test/java/org/apache/samza/system/kafka/MockKafkaProducer.java > 6f498de > samza-kafka/src/test/java/org/apache/samza/utils/TestUtils.java 2fa743f > > samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala > e6815da > > samza-kafka/src/test/scala/org/apache/samza/migration/TestKafkaCheckpointMigration.scala > 504fc89 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemAdmin.scala > f00405d > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemConsumer.scala > ece0359 > > samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala > 8e32bba > > samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala > 8d7e3fe > > Diff: https://reviews.apache.org/r/49212/diff/ > > > Testing > ------- > > Got `./gradlew clean check` passing. I've not been able to run the > integration tests (on any branch) but will do that next! > > > Thanks, > > Robert Crim > >
