> On July 12, 2016, 12:15 a.m., Fred Ji wrote:
> > samza-core/src/main/java/org/apache/samza/configbuilder/SerdeConfig.java,
> > line 43
> > <https://reviews.apache.org/r/48356/diff/7/?file=1441783#file1441783line43>
> >
> > Could serdeAlias be null accidentally? If so, it would be better to
> > have a null check for serdeAlias.
>
> Navina Ramesh wrote:
> SerdeAlias is an enum. I don't think you can specify a "null" value for
> enum.
>
> Fred Ji wrote:
> null can be assigned to an enum in Java.
Ah.. it doesn't recognize constructor of type (String, Object) for obvious
reasons :P So, new SerdeConfig("name", null) is not allowed.
However, it doesn't stop someone from specifying: SerdeAlias x = null; new
SerdeConfig("name", x); I will add the check. Thanks!
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48356/#review141799
-----------------------------------------------------------
On July 12, 2016, 6:45 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48356/
> -----------------------------------------------------------
>
> (Updated July 12, 2016, 6:45 p.m.)
>
>
> Review request for samza, Chris Pettitt and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> Added ConfigBuilder and support classes
>
> Added JobCoordinator interfaces
>
>
> Adding StreamProcessor, StandaloneJobCoordinator and updating SamzaContainer
> interface
>
>
> Added TestStreamProcessor and some unit tests for ConfigBuilders
>
>
> Changing who defined processorId
>
>
> Fixed checkstyle errors
>
>
> Replaced SamzaException with ConfigException
>
>
> Removing localityManager instantiation from Samza Container
>
>
> Diffs
> -----
>
> build.gradle ba4a9d14fe24e1ff170873920cd5eeef656955af
> checkstyle/import-control.xml 325c38131047836dc8aedaea4187598ef3ba7666
> samza-core/src/main/java/org/apache/samza/config/TaskConfigJava.java
> 021d42a70179f5d14f51ac87cb09dcc97218095e
>
> samza-core/src/main/java/org/apache/samza/configbuilder/CheckpointConfig.java
> PRE-CREATION
> samza-core/src/main/java/org/apache/samza/configbuilder/ConfigBuilder.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/configbuilder/GenericConfigBuilder.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/configbuilder/KafkaCheckpointConfig.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/configbuilder/KafkaSystemConfig.java
> PRE-CREATION
> samza-core/src/main/java/org/apache/samza/configbuilder/SerdeConfig.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/configbuilder/StandaloneConfigBuilder.java
> PRE-CREATION
> samza-core/src/main/java/org/apache/samza/configbuilder/SystemConfig.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/container/grouper/stream/AllSspToSingleTaskGrouper.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/container/grouper/stream/AllSspToSingleTaskGrouperFactory.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/container/grouper/task/SingleContainerGrouper.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/container/grouper/task/SingleContainerGrouperFactory.java
> PRE-CREATION
> samza-core/src/main/java/org/apache/samza/coordinator/JobCoordinator.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/coordinator/JobCoordinatorFactory.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/coordinator/JobModelUpdateHandler.java
> PRE-CREATION
> samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinator.java
> PRE-CREATION
>
> samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinatorFactory.java
> PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala
> 49b08f6b68dbb44757dcc8ce8d60c365a9d22981
> samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala
> 08a4debb06f9925ae741049abb2ee0df97b2243b
> samza-core/src/main/scala/org/apache/samza/container/RunLoop.scala
> cf05c15c836ddfa54ba8fe27abc18ed88ac5fc11
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
> 18c09224bbae959342daf9b2b7a7d971cc224f48
> samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala
> d3bd9b7c11afd44ccfb681b660fefffafd216c29
> samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala
> 56881d46be9f859999adabbbda20433b208e012e
>
> samza-core/src/test/java/org/apache/samza/configbuilder/TestStandaloneConfigBuilder.java
> PRE-CREATION
> samza-test/src/test/java/org/apache/samza/processor/MyStreamTask.java
> PRE-CREATION
>
> samza-test/src/test/java/org/apache/samza/processor/TestStreamProcessor.java
> PRE-CREATION
> samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java
> 8f2dc4853a2b5dd712f25a2d2d16402bcba89d7a
> samza-yarn/src/main/java/org/apache/samza/job/yarn/SamzaTaskManager.java
> bc95f31c0dcaaa68d483a6f152b61aba6c543fff
>
> Diff: https://reviews.apache.org/r/48356/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
> Local integration test:
> ./bin/grid start zookeeper
> ./bin/grid start kafka
> Then, run TestStreamProcessor.java
>
>
> Thanks,
>
> Navina Ramesh
>
>
