> On July 29, 2016, 9:30 p.m., Yi Pan (Data Infrastructure) wrote: > > docs/_config.yml, line 26 > > <https://reviews.apache.org/r/50614/diff/1/?file=1458161#file1458161line26> > > > > Single quotation marks are mandatory here. Otherwise, the tool we use > > will parse this as a float number and fail. > > > > Also, we have never publised a 0.x.1 online doc site since 0.8. It > > should be OK if we just overwrite the current 0.10 online doc site.
OK. I take it back. 0.10.1 should compile fine, as we have 0.7.0 before. 0.10 will be treated as float number and make it 0.1 version, which is not OK. Anyways, I found adding the single quotation mark is more reliable, since it forces the parser to treat it as string. - Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50614/#review144204 ----------------------------------------------------------- On July 29, 2016, 9:04 p.m., Navina Ramesh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50614/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 9:04 p.m.) > > > Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data > Infrastructure). > > > Bugs: SAMZA-987 > https://issues.apache.org/jira/browse/SAMZA-987 > > > Repository: samza > > > Description > ------- > > SAMZA-987 - Preparing for 0.10.1 version release > > > Diffs > ----- > > bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469 > docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c > docs/startup/hello-samza/versioned/index.md > e1ef4da845fdc7ecb42456b834a112986c13a5d5 > gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf > samza-test/src/main/python/configs/tests.json > 30be820d1f8f27629ab15f853533d558af8b53a5 > samza-test/src/main/python/requirements.txt > 2ae95908248516b5b26e671f24fa680f7b801675 > samza-test/src/main/python/samza_job_yarn_deployer.py > 38635ca5899c43fb61d6b4042e8543f0508fd41b > > Diff: https://reviews.apache.org/r/50614/diff/ > > > Testing > ------- > > ./bin/check-all.sh > > > Thanks, > > Navina Ramesh > >
