-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50619/
-----------------------------------------------------------
(Updated Aug. 5, 2016, 10:27 p.m.)
Review request for samza, Chris Pettitt, Jake Maes, and Yi Pan (Data
Infrastructure).
Changes
-------
addressing Yi's comments.
Bugs: SAMZA-963
https://issues.apache.org/jira/browse/SAMZA-963
Repository: samza
Description
-------
SAMZA-963: add KV storage engine timers to help identify the issues on kv
stores and also add unit test
Diffs (updated)
-----
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala
a3ffc421020b7a84c40b2101f2e37db8a20690cb
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineMetrics.scala
233fba91caf041bfb78189efef00ce8fc56f9f15
samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStorageEngine.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/50619/diff/
Testing
-------
1. unit test is successful on a newly created test file for
KeyValueStorageEngine: ./gradlew clean :samza-kv_2.10:test
-Dtest.single=TestKeyValueStorageEngine
2. build and all unit tests are successful: ./gradlew clean build
3. ./gradlew checkstyleMain checkstyleTest passed
4. manually tested on local machine for a stateful sample job depending on
KVStore, and from jconsole, the corresponding metrics were seen in mbeans (see
attached file) and the metrics were updated as expected.
File Attachments
----------------
snapshot of KeyValueStorageEngineMetrics bean from jconsole on local test
https://reviews.apache.org/media/uploaded/files/2016/07/29/ce4b0456-73f9-44d5-af7d-0c45bf91bcaa__KeyValueStorageEngineMetricsFromJconsole.png
Thanks,
Fred Ji
