> On Aug. 30, 2016, 1 a.m., Xinyu Liu wrote:
> > docs/learn/documentation/versioned/jobs/configuration-table.html, line 368
> > <https://reviews.apache.org/r/50174/diff/2/?file=1455861#file1455861line368>
> >
> >     oh, actually the job.container.single.thread.mode  means using the old 
> > runloop which supports single thread execution only. It is default as false 
> > so we will use AsyncRunLoop. I plan to get rid of RunLoop in 11.1 once 
> > AsyncRunLoop is fully stablized.

If you are planning to remove support for some of the existing features or 
config (like runloop and single.thread.mode), it is common practice to mark it 
as deprecated and remove it in the next major release. It will be better to 
state this fact in the documentation now so that users know that this config is 
going away.


- Navina


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50174/#review147252
-----------------------------------------------------------


On Sept. 7, 2016, 5:16 p.m., Xinyu Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50174/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 5:16 p.m.)
> 
> 
> Review request for samza, Chris Pettitt, Navina Ramesh, and Yi Pan (Data 
> Infrastructure).
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Update samza web docs with new multithreading api, core and configs.
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/api/overview.md 
> 6712344e84e19883b857e00549db2acb101c7e0e 
>   docs/learn/documentation/versioned/container/event-loop.md 
> 116238312df7071747cbbc14bc9c46f558755195 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 
> 54c52981c3055b398ee60af50eeaf2592ed0e64f 
> 
> Diff: https://reviews.apache.org/r/50174/diff/
> 
> 
> Testing
> -------
> 
> Test the web pages locally.
> 
> 
> Thanks,
> 
> Xinyu Liu
> 
>

Reply via email to