----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52492/ -----------------------------------------------------------
(Updated Oct. 31, 2016, 11:04 p.m.) Review request for samza. Repository: samza Description ------- This patch contains the samza-rest monitor that periodically cleans up the stale local stores of dead jobs/tasks. It performs the store deletion in two phases. Initially it deletes the offset file in the local task stores if the following condition is true. ((jobIsNotRunning || preferedHost != nmHost) && offsetFilelastModifiedTime is greater than deleteRetention). During the subsequent run, it deletes the local task stores if it does not contain offset file. Please refer to the design doc of SAMZA-656 (https://issues.apache.org/jira/secure/attachment/12828083/DESIGN-SAMZA-656.pdf) for more details. Diffs (updated) ----- build.gradle 2bea27b75288d3103178bc3762b9556f6e69cdd1 samza-rest/src/main/java/org/apache/samza/monitor/JobsClient.java PRE-CREATION samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitor.java PRE-CREATION samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorConfig.java PRE-CREATION samza-rest/src/main/java/org/apache/samza/monitor/LocalStoreMonitorFactory.java PRE-CREATION samza-rest/src/main/java/org/apache/samza/rest/resources/ResourceConstants.java PRE-CREATION samza-rest/src/test/java/org/apache/samza/monitor/TestLocalStoreMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/52492/diff/ Testing ------- Unit testing and manual testing are done to verify the functionality. Thanks, Shanthoosh Venkataraman
