> On Nov. 5, 2016, 6:47 p.m., Jake Maes wrote: > > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java, line > > 75 > > <https://reviews.apache.org/r/53297/diff/1/?file=1549407#file1549407line75> > > > > I don't think the MetricsConfig constructure takes a subset. > > > > I think it takes the root and expects to find the "metrics" prefix > > Jake Maes wrote: > s/constructure/constructor > > phonetic brain fail > > Shanthoosh Venkataraman wrote: > Yes, that's true. It expects the root and finds the metrics prefix. > Hence, stripPrefix is passed on as false, so that prefix isn't removed. This > just selects the config subset that starts with METRICS_PREFIX, without > removing the prefix. The goal is to not pass on the entire config object and > pass only metrics related config into MetricsConfig constructor. > > Prateek Maheshwari wrote: > Regarding the goal: That's not how the XConfig classes are intended to be > used, so it's not really necessary to do this. For example, see the implicit > conversion b/w Config and XConfig. Prefer passing in config.
Done. - Shanthoosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53297/#review155061 ----------------------------------------------------------- On Nov. 10, 2016, 1:04 a.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53297/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 1:04 a.m.) > > > Review request for samza and Jake Maes. > > > Repository: samza > > > Description > ------- > > This patch aims at enabling users to define custom reporters to send metrics > from the monitors. Configurations required for the definition of the metrics > reporters follows the same convention as of the samza jobs. > > > Diffs > ----- > > docs/learn/documentation/versioned/rest/monitors.md > 46678bbe5fed99f767c3324dc9578ee1a64cec66 > samza-core/src/main/java/org/apache/samza/util/MetricsReporterLoader.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > e0468ee89c89fd720834461771ebb36475475bcb > > samza-core/src/main/scala/org/apache/samza/metrics/ContainerProcessManagerMetrics.scala > f24beb1e099dd44b15b475e0a4a7f70560c6965e > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java > 47b0663637f6db187d86961377ee3ee203b73fdb > samza-rest/src/main/java/org/apache/samza/rest/SamzaRestService.java > 2a3e83a24a5343bb53b93fc9d0a647c1b253714b > samza-rest/src/test/java/org/apache/samza/rest/TestSamzaRestService.java > PRE-CREATION > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala > 8a5b4aaea6e11a5af999f12d50e5b6135dbc70ca > > Diff: https://reviews.apache.org/r/53297/diff/ > > > Testing > ------- > > Unit tests are done to verify the intended functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
