----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review162971 -----------------------------------------------------------
Fix it, then Ship it! Looks good. Have a few minor comments about adding javadoc links. Please test the changes locally after finalizing. docs/learn/documentation/versioned/hdfs/consumer.md (line 22) <https://reviews.apache.org/r/52570/#comment234345> Please link HdfsSystemConsumer to java doc. docs/learn/documentation/versioned/hdfs/consumer.md (line 32) <https://reviews.apache.org/r/52570/#comment234346> camel case HdfsSystemConsumer? link to Java doc. docs/learn/documentation/versioned/hdfs/consumer.md (line 34) <https://reviews.apache.org/r/52570/#comment234347> replace 'SystemStreamPartition" with partitions? docs/learn/documentation/versioned/hdfs/consumer.md (line 40) <https://reviews.apache.org/r/52570/#comment234348> java doc link to HdfsSystemConsumer, IncomingMessageEvelope and GenericRecord. docs/learn/documentation/versioned/hdfs/consumer.md (line 42) <https://reviews.apache.org/r/52570/#comment234349> please link java doc to SingleFileHdfsReader, instead of putting the file name here. - Xinyu Liu On Jan. 24, 2017, 2:07 a.m., Hai Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52570/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:07 a.m.) > > > Review request for samza. > > > Bugs: SAMZA-1025 > https://issues.apache.org/jira/browse/SAMZA-1025 > > > Repository: samza > > > Description > ------- > > documentation for hdfs system consumer > > > Diffs > ----- > > docs/learn/documentation/versioned/hdfs/consumer.md PRE-CREATION > docs/learn/documentation/versioned/hdfs/producer.md > b0e936f5b0a9c945ea7f02bfc2536ef50f017bf6 > docs/learn/documentation/versioned/index.html > d0b14ece94341e2cb937cf32db480e69f93303c2 > docs/learn/documentation/versioned/jobs/configuration-table.html > ba5ebbc54b5c64f82f35ed781dad7023a8f920e1 > > Diff: https://reviews.apache.org/r/52570/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Hai Lu > >