----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52570/#review163355 -----------------------------------------------------------
Fix it, then Ship it! Some nits and comments. Otherwise, looks good. Thanks! +1 docs/learn/documentation/versioned/hdfs/consumer.md (line 39) <https://reviews.apache.org/r/52570/#comment234764> This line is confusing. Are you implying that I can read from non-avro formatted files that are in HDFS ? What is the significance of the SingleFileHdfsReader interface ? It is not clear to the reader. docs/learn/documentation/versioned/hdfs/consumer.md (line 89) <https://reviews.apache.org/r/52570/#comment234762> Nit: Can you move the explanation of what advanced partitioning is outside of the code block? You can emphasize the reserved term note by doing -> **note** , when it is outside the code block docs/learn/documentation/versioned/jobs/configuration-table.html (line 1822) <https://reviews.apache.org/r/52570/#comment234763> Look like a typo. It should "systems.*, instead of "system.*" ? - Navina Ramesh On Jan. 27, 2017, 5:48 p.m., Hai Lu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52570/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 5:48 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-1025 > https://issues.apache.org/jira/browse/SAMZA-1025 > > > Repository: samza > > > Description > ------- > > documentation for hdfs system consumer > > > Diffs > ----- > > docs/learn/documentation/versioned/hdfs/consumer.md PRE-CREATION > docs/learn/documentation/versioned/hdfs/producer.md > b0e936f5b0a9c945ea7f02bfc2536ef50f017bf6 > docs/learn/documentation/versioned/index.html > d0b14ece94341e2cb937cf32db480e69f93303c2 > docs/learn/documentation/versioned/jobs/configuration-table.html > ba5ebbc54b5c64f82f35ed781dad7023a8f920e1 > > Diff: https://reviews.apache.org/r/52570/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Hai Lu > >
