> On Feb. 8, 2017, 8:43 p.m., Jake Maes wrote: > > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala, > > line 177 > > <https://reviews.apache.org/r/52476/diff/4-6/?file=1541857#file1541857line177> > > > > Looks like this log statement belongs in an else-block. It says the > > store is stale, but in this block, we've determined hasValidOffsetFile=true. > > > > Also the wording isn't entirely accurate. The offset file may be > > present, but empty. It might be better to say "Offset file is not valid for > > store: %s"
My bad, this minor thing was missed while refactoring. Thanks for pointing it out. Fixed. - Shanthoosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52476/#review164765 ----------------------------------------------------------- On Feb. 8, 2017, 9:37 p.m., Shanthoosh Venkataraman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52476/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 9:37 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Every local task store is backed up by a kafka changelog topic. Due to log > compaction, delete tombstones of the changelog topic have a ttl of > delete.retention.ms. Replaying the events from the changelog that has missing > delete tombstones, would result in creation of an inconsistent local > store(due to the missing of some delete events). This patch deletes the local > stores in which difference between current time and last modified time of the > offset file is greater than delete.retention.ms during the container startup. > > > Diffs > ----- > > samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java > 9329edf7d724f3a0d9235354bb77936f713e3b5f > samza-core/src/main/scala/org/apache/samza/config/StorageConfig.scala > a3587d0a40c57374ee1742234929d444e381e42d > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > c3308bfd7de04c335fef6cb66baa29286a230080 > samza-core/src/main/scala/org/apache/samza/storage/TaskStorageManager.scala > 0b7bcdda1639eea8239a69c31bdf42558e9077d2 > > samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala > 4d40f520e54beb643acd8410c772b75e2f6a9162 > samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala > 9320cf744ff90d647a198b51cb06d2a526fe68fa > > Diff: https://reviews.apache.org/r/52476/diff/ > > > Testing > ------- > > Unit testing and manual testing has been done to verify the functionality. > > > Thanks, > > Shanthoosh Venkataraman > >
