GitHub user shanthoosh opened a pull request:
https://github.com/apache/samza/pull/124
SAMZA-1209: Improve error handling in LocalStoreMonitor
Changes:
1. Add opt-in configuration to continue garbage collection of local stores
when thereâs a failure in garbage collecting one local store.
2. Handle failures gracefully. In getJobModel, JobModel is expected as
return response.
Incase of failures, returned error-message Map is deserialized to
JobModel
resulting in ClassCastException. Handle 2xx, failures separately. Log
error
messages returned properly in httpGet call.
3. Fix getTasks url format.
4. Minor code cleanup(Switch to using ',' as seperator for
job.status.servers configuration
instead of '.' for ease of use).
5. Fix disabled tests in TestLocalStoreMonitor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shanthoosh/samza
fix_config_format_in_localstore_monitor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit c4a344ae7afc463346e3450548255d13b1bd7676
Author: Shanthoosh Venkataraman <[email protected]>
Date: 2017-04-12T16:53:19Z
SAMZA-1209: Improve error handling in LocalStoreMonitor
Changes:
1. Add opt-in configuration to continue garbage collection of local stores
when thereâs a failure in garbage collecting one local store.
2. Handle failures gracefully. In getJobModel, JobModel is expected as
return response.
Incase of failures, returned error-message Map is deserialized to
JobModel
resulting in ClassCastException. Handle 2xx, failures separately. Log
error
messages returned properly in httpGet call.
3. Fix getTasks url format.
4. Minor code cleanup(Switch to using ',' as seperator for
job.status.servers configuration
instead of '.' for ease of use).
5. Fix disabled tests in TestLocalStoreMonitor.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
