----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58851/ -----------------------------------------------------------
Review request for samza and Prateek Maheshwari. Repository: samza Description ------- (Same as PR - https://github.com/apache/samza/pull/148) See SAMZA-1212 for motivation toward this refactoring. Changes here are: - Removed awaitStart (blocking) method in StreamProcessor, JobCoordinator and SamzaContainer - Introduced SamzaContainerListener and JobCoordinatorListener interface implemented by StreamProcessor - Introduced SamzaContainerStatus to handler failures and lifecycle using Listener interfaces Diffs ----- samza-core/src/main/java/org/apache/samza/SamzaContainerStatus.java PRE-CREATION samza-core/src/main/java/org/apache/samza/coordinator/JobCoordinator.java af2ef6a0338a0f0ab015e615a5dc213941095801 samza-core/src/main/java/org/apache/samza/coordinator/JobCoordinatorFactory.java 7f7e1ede822cf16b78e6e753ebc083a17ebf2aca samza-core/src/main/java/org/apache/samza/processor/JobCoordinatorListener.java PRE-CREATION samza-core/src/main/java/org/apache/samza/processor/SamzaContainerController.java 4af413a14aaa3976f45b0646a3feb745ea3f0e97 samza-core/src/main/java/org/apache/samza/processor/SamzaContainerListener.java PRE-CREATION samza-core/src/main/java/org/apache/samza/processor/StreamProcessor.java 191059443e3d65869207a5f1e11526f97833f468 samza-core/src/main/java/org/apache/samza/processor/StreamProcessorLifecycleListener.java 7bca074a4d83bb9bc2434b6769ecf39c5694e2f9 samza-core/src/main/java/org/apache/samza/runtime/LocalContainerRunner.java 80350dfc02b577faf0dce00cf5695c23d202ad9c samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinator.java 0d74fb82590ba6f183905c9b0328b16d88adc0ab samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinatorFactory.java 0faeca917aa5fb12acef9fb539d81a01255a0441 samza-core/src/main/java/org/apache/samza/zk/ZkBarrierForVersionUpgrade.java 0afd840dc2083dc78b853423f27776d6b5a2538f samza-core/src/main/java/org/apache/samza/zk/ZkControllerImpl.java 61f78762a3a1a50687ec00f783685f53d17bd645 samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinator.java 2535654cee37feeb472517b8673a7bb12b3cc1fc samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinatorFactory.java a44565c083dc73b0f5d56174d82e9ae62136cf02 samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 8481c92b5666710edd8381526f824daed4dd27c5 samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala dcef3af45bf5fe139be7744276adaddac3fb3505 samza-core/src/test/java/org/apache/samza/processor/TestStreamProcessor.java PRE-CREATION samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 010ff7e85ff1c5e507f3e9fa7d6c196b58d929ab samza-core/src/test/scala/org/apache/samza/processor/StreamProcessorTestUtils.scala PRE-CREATION samza-kafka/src/test/java/org/apache/samza/system/kafka/TestKafkaSystemAdminJava.java a786468722cc49b4b6c3c67d89a6b09f1be4c939 samza-test/src/test/java/org/apache/samza/test/processor/TestStreamProcessor.java f37a224f64eec162e60e3a891b257175dbf4ec3c samza-test/src/test/scala/org/apache/samza/test/integration/StreamTaskTestUtil.scala 29fb6d3f6e07f356d4a25556221fa76ecdc7bf77 Diff: https://reviews.apache.org/r/58851/diff/1/ Testing ------- unit tests and ./gradlew clean build Thanks, Navina Ramesh
