GitHub user thunderstumpges opened a pull request:
https://github.com/apache/samza/pull/450
ScheduleAfterDebounceTime should catch all Throwable to avoid losing
unhandled Errors
If an Action executed in the scheduler throws an Error (or other
Throwable?) besides Exception, it is silently lost since the Action/Runnable
wrapper only catches Exception, not Throwable. This made my troubleshooting of
an issue very difficult. Made it seem like the code was "hung" when really it
had thrown a "NoSuchMethodError" (Error instead of Exception) due to a simple
dependency issue on my side.
Catching Throwable instead ensures this is handled and propagated properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ntent-ad/samza scheduler-catch-throwable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #450
----
commit cefcdd2486b1a9ca2d075cad76c69dc60c1ced49
Author: thunderstumpges <tstumpges@...>
Date: 2018-03-19T23:32:39Z
ScheduleAfterDebounceTime action should catch all Throwable to avoid
uncaught exceptions being lost.
----
---
