GitHub user ahmedahamid opened a pull request:

    https://github.com/apache/samza/pull/497

    SAMZA-1243: Fix flaky tests in TestLocalStoreMonitor

    Having attempted to reproduce this issue without success, careful analysis 
of the code indicates the underlying issue is most likely incomplete cleanup of 
file system directories after test execution possibly due to incomplete or 
manual test runs. To address this issue, this fix generates a different local 
store directory for every test to isolate file system side-effects across 
different tests and test runs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahmedahamid/samza dev/fix-1243

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/497.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #497
    
----
commit 5ad2f47545b6c33fb389ab0d3231ea041d1ca7f5
Author: Ahmed Abdul Hamid <ahabdulh@...>
Date:   2018-04-30T22:15:18Z

    SAMZA-1243: Fix flaky tests in TestLocalStoreMonitor
    
    Having attempted to reproduce this issue without success, careful analysis 
of the code indicates the underlying issue is most likely incomplete cleanup of 
file system directories after test execution possibly due to incomplete manual 
test runs. To address this issue, this fix generates a different local store 
directory for every test to isolate file system side-effects across different 
tests and test runs.

----


---

Reply via email to