GitHub user ahmedahamid opened a pull request:
https://github.com/apache/samza/pull/500
SAMZA-1696: Fix TestKeyValueStores flaky test
Fix flaky test testParallelReadWriteSameKey that was failing due to a race
condition between the main test thread and the thread manipulating the key
value store under test. Specifically, the main test thread could assert the
store has received a value before the other thread gets to set it. The
hard-coded wait durations did not guarantee the main test thread would wait for
all other threads to complete, causing it to assert prematurely.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahmedahamid/samza dev/fix-1696
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #500
----
commit 36a2a1b09d6fa0216d556e594e566918f52295a2
Author: Ahmed Abdul Hamid <ahabdulh@...>
Date: 2018-05-02T17:26:28Z
SAMZA-1696: Fix TestKeyValueStores flaky test
Fix flaky test testParallelReadWriteSameKey that was failing due to a race
condition between the main test thread and the thread manipulating the key
value store under test. Specifically, the main test thread could assert the
store has received a value before the other thread gets to set it. The
hard-coded wait durations did not guarantee the main test thread would wait for
all other threads to complete, causing it to assert prematurely.
----
---
