GitHub user cameronlee314 opened a pull request:
https://github.com/apache/samza/pull/509
SAMZA-1700 : Clean up SystemAdmins instance creation flows
The SystemAdmins class has a special "test" constructor for building
SystemAdmins instances for unit tests. However, that test constructor has
leaked into non-test code.
This makes it harder to manage all flows which use SystemAdmins. An
upcoming change is to fix lifecycle management for SystemAdmins in the
ApplicationRunner classes, so doing some clean up will help that future change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cameronlee314/samza systemadmins_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit 61912e94dc1ed382f693c59ddd9d1c8add45c694
Author: Cameron Lee <calee@...>
Date: 2018-05-08T17:28:22Z
SAMZA-1700 : Clean up SystemAdmins instance creation flows
commit d672e02c42cfd06e9c4ac7f6c8b055522f8481bc
Author: Cameron Lee <calee@...>
Date: 2018-05-08T17:44:51Z
accidentally changed TestApplicationRunnerMain in initial commit; reverting
the change to that file
----
---
