GitHub user Sanil15 opened a pull request:
https://github.com/apache/samza/pull/764
Samza 1967: Tests failing when Job uses any serde other than NoOp
Context: Serde is configured in JobNodeConfigurationGenerator and any
StreamDescriptor#toConfig does not generate key and msg serde configs
Problem: Tests failing when Job uses any serde other than NoOp, since
ApplicationDescriptor serdes take precedence in absence of any user-supplied
configs
Solution: Passing null msg and key serde configs in userConfigs for
StreamDescriptors ensures ApplicationDescriptor generated serde configs don't
take precedence
@prateekm @rmatharu please take a look
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Sanil15/samza SAMZA-1967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/764.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #764
----
commit 7dc04459a6719749e028c182dfb6f89fcaba09bd
Author: Sanil15 <sanil.jain15@...>
Date: 2018-10-26T00:46:40Z
Ensure serde configs for NoOpSerdes from InMemoryStreamDescriptors take
precedence over AppDescriptor configs
commit 154433fd52bf195db147296930896a1098adab9d
Author: Sanil15 <sanil.jain15@...>
Date: 2018-10-26T00:48:44Z
Removing a Typo
----
---
