prateekm commented on a change in pull request #927: SAMZA-2111: Refactoring
ApplicationRunnerMain code
URL: https://github.com/apache/samza/pull/927#discussion_r259036992
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/ApplicationRunnerMain.java
##########
@@ -50,8 +50,12 @@ public static void main(String[] args) throws Exception {
ApplicationRunnerCommandLine cmdLine = new ApplicationRunnerCommandLine();
OptionSet options = cmdLine.parser().parse(args);
Config orgConfig = cmdLine.loadConfig(options);
- Config config = Util.rewriteConfig(orgConfig);
ApplicationRunnerOperation op = cmdLine.getOperation(options);
+ invokeApplicationRunner(orgConfig, op);
+ }
+
+ public static ApplicationRunner invokeApplicationRunner(Config orgConfig,
ApplicationRunnerOperation op) {
+ Config config = Util.rewriteConfig(orgConfig);
Review comment:
Config rewrite shouldn't happen in this method since it's orthogonal to rest
of the functionality and is already available as a util.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
