rmatharu commented on a change in pull request #912: SEP-19 : Refactoring
sideInputs from SamzaContainer to ContainerStorageManager
URL: https://github.com/apache/samza/pull/912#discussion_r259205224
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -729,11 +1058,16 @@ public void stop() {
* can invoke compaction.
*/
public void stopPersistentStores() {
- this.taskStores.values().stream().filter(storageEngine -> {
- return storageEngine.getStoreProperties().isPersistedToDisk();
- }).forEach(storageEngine -> {
- storageEngine.stop();
- });
+
+ Map<String, StorageEngine> persistentStores =
this.taskStores.entrySet().stream().filter(e -> {
Review comment:
No this wont, note that this is inside TaskRestoreManager, which only
handles changelogged stores.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
