mynameborat commented on a change in pull request #912: SEP-19 : Refactoring sideInputs from SamzaContainer to ContainerStorageManager URL: https://github.com/apache/samza/pull/912#discussion_r260972229
########## File path: samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java ########## @@ -109,19 +142,43 @@ private final int parallelRestoreThreadPoolSize; private final int maxChangeLogStreamPartitions; // The partition count of each changelog-stream topic. This is used for validating changelog streams before restoring. + /* Sideinput related parameters */ + private final Map<String, Set<SystemStream>> sideInputSystemStreams; // Map of side input system-streams indexed by store name + private final Map<TaskName, Map<String, Set<SystemStreamPartition>>> taskSideInputSSPs; + private final Map<TaskName, Map<String, SideInputsProcessor>> taskSideInputProcessors; + private final Map<SystemStreamPartition, TaskSideInputStorageManager> sideInputStorageManagers; // Map of sideInput storageManagers indexed by ssp, for simpler lookup for process() + private final Map<String, SystemConsumer> sideInputConsumers; // Mapping from storeSystemNames to SystemConsumers + private SystemConsumers sideInputSystemConsumers; + private final Map<SystemStreamPartition, SystemStreamMetadata.SystemStreamPartitionMetadata> initialSideInputSSPMetadata + = new ConcurrentHashMap<>(); // Recorded sspMetadata of the taskSideInputSSPs recorded at start, used to determine when sideInputs are caughtup and container init can proceed + private volatile CountDownLatch sideInputsCaughtUp; // Used by the sideInput-read thread to signal to the main thread + private volatile boolean shutDownSideInputRead = false; + private final ScheduledExecutorService sideInputsFlushExecutor = Executors.newSingleThreadScheduledExecutor( + new ThreadFactoryBuilder().setNameFormat(SIDEINPUTS_FLUSH_THREAD_NAME).build()); Review comment: Can you set the thread to be daemon? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
