cameronlee314 commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r261355687
########## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OperatorImplGraph.java ########## @@ -24,38 +24,23 @@ import org.apache.samza.config.Config; import org.apache.samza.config.StreamConfig; import org.apache.samza.context.Context; +import org.apache.samza.context.JobContextMetadata; import org.apache.samza.context.TaskContextImpl; import org.apache.samza.job.model.JobModel; import org.apache.samza.operators.KV; import org.apache.samza.operators.OperatorSpecGraph; import org.apache.samza.operators.Scheduler; import org.apache.samza.operators.functions.JoinFunction; import org.apache.samza.operators.functions.PartialJoinFunction; -import org.apache.samza.operators.spec.BroadcastOperatorSpec; -import org.apache.samza.operators.spec.InputOperatorSpec; -import org.apache.samza.operators.spec.JoinOperatorSpec; -import org.apache.samza.operators.spec.OperatorSpec; -import org.apache.samza.operators.spec.OutputOperatorSpec; -import org.apache.samza.operators.spec.PartitionByOperatorSpec; -import org.apache.samza.operators.spec.SendToTableOperatorSpec; -import org.apache.samza.operators.spec.SinkOperatorSpec; -import org.apache.samza.operators.spec.StreamOperatorSpec; -import org.apache.samza.operators.spec.StreamTableJoinOperatorSpec; -import org.apache.samza.operators.spec.WindowOperatorSpec; +import org.apache.samza.operators.spec.*; import org.apache.samza.storage.kv.KeyValueStore; import org.apache.samza.system.SystemStream; import org.apache.samza.util.Clock; import org.apache.samza.util.TimestampedValue; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.ArrayList; -import java.util.Collection; -import java.util.Collections; -import java.util.HashMap; -import java.util.LinkedHashMap; -import java.util.List; -import java.util.Map; +import java.util.*; Review comment: same as above about wildcard imports ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
