Cpptz commented on a change in pull request #934: SAMZA-1935 : Refactor
TaskContextImpl to not include access to objects that are only used internally
URL: https://github.com/apache/samza/pull/934#discussion_r261860117
##########
File path:
samza-core/src/test/java/org/apache/samza/operators/impl/TestWindowOperator.java
##########
@@ -436,13 +434,6 @@ public void testCancelationOfRepeatingNestedTriggers()
throws Exception {
@Test
public void testEndOfStreamFlushesWithEarlyTriggerFirings() throws Exception
{
- EndOfStreamStates endOfStreamStates = new
EndOfStreamStates(ImmutableSet.of(new SystemStreamPartition("kafka",
Review comment:
Well first of all, as the JobContextMetadata is instanciated inside the
OperatorImplGraph, we have no reference to it in this test, therefore we didn't
know how to mock it.
And infact, we found that the mocking wasn't necessary if we simply set the
correct stream name in the setup, namely `integers` instead of
`integTestExecutionPlannerers` since tests are done with the stream name
`integers`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
