Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262266827
########## File path: samza-core/src/main/java/org/apache/samza/util/JobConfigUtil.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.util; + +import java.util.HashMap; +import java.util.Map; +import org.apache.samza.config.ApplicationConfig; +import org.apache.samza.config.JobConfig; +import org.apache.samza.config.MapConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class JobConfigUtil { + private static final Logger LOG = LoggerFactory.getLogger(JobConfigUtil.class); + + /** + * Generates job.id from app.id and job.name from app.name config + * If both job.id and app.id is defined, app.id takes precedence and job.id is set to value of app.id + * If both job.name and app.name is defined, app.name takes precedence and job.name is set to value of app.name + * + * @param userConfigs configs passed from user + * + */ + public static MapConfig generateJobIdAndName(MapConfig userConfigs) { Review comment: will do ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
