prateekm commented on a change in pull request #942: Bugfix: Recent CSM
refactor was causing some metrics to not be emitted. Fixed <task>-restore-time
metric.
URL: https://github.com/apache/samza/pull/942#discussion_r263877257
##########
File path:
samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala
##########
@@ -19,12 +19,13 @@
package org.apache.samza.system
-import org.apache.samza.metrics.MetricsRegistry
import org.apache.samza.metrics.MetricsRegistryMap
import org.apache.samza.metrics.Counter
import org.apache.samza.metrics.MetricsHelper
+import org.apache.samza.metrics.ReadableMetricsRegistry
-class SystemConsumersMetrics(val registry: MetricsRegistry = new
MetricsRegistryMap) extends MetricsHelper {
+class SystemConsumersMetrics(val registry: ReadableMetricsRegistry = new
MetricsRegistryMap,
+ val prefix: String = "") extends MetricsHelper {
Review comment:
We discussed offline, source is a TaskInstance metrics specific thing and
should be removed. 'prefix' has similar semantics and is the better way to do
this. @rmatharu please add the ticket here with the discussion summary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
