mynameborat commented on a change in pull request #938: SAMZA-1531: Support
run.id in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r264944248
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -200,6 +279,22 @@ static String createProcessorId(ApplicationConfig
appConfig) {
}
}
+ private void cleanup() {
+ if(runIdLock != null) {
+ runIdLock.cleanState();
+ }
+ if(coordinationUtils != null) {
+ coordinationUtils.close();
+ }
+ }
+
+ private void stopProcessingAndShutDown() {
+ processors.forEach(StreamProcessor::stop);
+ cleanup();
+ appStatus = ApplicationStatus.UnsuccessfulFinish;
Review comment:
I see why this is a confusion. can we take in an exception instead and set
the state based on the exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
