shanthoosh commented on a change in pull request #951: SAMZA-2127: Upgrade to
Kafka 2.0
URL: https://github.com/apache/samza/pull/951#discussion_r268386258
##########
File path:
samza-test/src/test/java/org/apache/samza/test/framework/StreamApplicationIntegrationTestHarness.java
##########
@@ -295,4 +227,20 @@ public Config getConfig() {
return this.config;
}
}
+
+ @Override
+ protected KafkaProducer createProducer() {
Review comment:
> If it is difficult to make them consistent, could you please put a comment
about why you have these overrides
Currently, yarn-integration-tests and standalone-integration-tests use
different serde's for producer/consumer. Reason was from initial stages of
development, both of them were using different integration-test-harness viz
`StreamApplicationIntegrationTestHarness`, `StandaloneIntegrationTestHarness`
though most of the logic in them were same. Unifying serde's would be
non-trivial and can be done cleanly in a different follow-up patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
