shenodaguirguis commented on a change in pull request #966: Moving the Fixes 
from internal AvroRelConverter
URL: https://github.com/apache/samza/pull/966#discussion_r268405483
 
 

 ##########
 File path: 
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
 ##########
 @@ -170,22 +179,22 @@ static public GenericRecord 
convertToGenericRecord(SamzaSqlRelRecord relRecord,
               schema.getName(), schema.getNamespace(), fieldName);
           continue;
         }
-
         Object relObj = values.get(index);
+        if (relObj == null) {
 
 Review comment:
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to