srinipunuru commented on a change in pull request #966: Moving the Fixes from
internal AvroRelConverter
URL: https://github.com/apache/samza/pull/966#discussion_r268731436
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
##########
@@ -271,45 +281,46 @@ public Object convertToJavaObject(Object avroObj, Schema
schema) {
}
}
- private boolean isSchemaCompatible(Object avroObj, Schema unionSchema) {
- if (unionSchema.getType() == Schema.Type.NULL && avroObj == null) {
- return true;
+ private static boolean isSchemaCompatibleWithRelObj(Object relObj, Schema
unionSchema) {
+ if (unionSchema.getType() == Schema.Type.NULL) {
Review comment:
I am not sure i understand the comment. Are you asking whether we should
handle null values for unionSchema?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
