dxichen commented on a change in pull request #974: SAMZA-2147: Improve the
documentation of the samza release process.
URL: https://github.com/apache/samza/pull/974#discussion_r268911456
##########
File path: RELEASE.md
##########
@@ -103,48 +127,54 @@ from reading keyboard input (because we need
`org.gradle.jvmargs` set).
Build binary artifacts and upload them to the staging repository:
+ ```bash
# Set this to the oldest JDK which we are currently supporting for Samza.
# If it's built with Java 8, the classes won't be readable by Java 7.
export
JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_20.jdk/Contents/Home
./gradlew clean uploadArchives
+ ```
Go to [repository web interface](https://repository.apache.org/), log in with
Apache LDAP credentials, go to "Staging Repositories", select the
org.apache.samza
repository just created, and close it. This may take a minute or so. When it
finishes, the UI shows a staging repository URL. This can be used in a project
that depends on Samza, to test the release candidate.
-
-If the VOTE has successfully passed on the release candidate, you can log in
to the
-[repository web interface](https://repository.apache.org) (same as above) and
"release"
-the org.apache.samza repository listed under "Staging Repositories".
-
The instructions above publish the Samza artifacts for scala 2.11. To publish
for scala 2.12:
* Set the desired `scalaSuffix` in `gradle.properties`.
* Run `./gradlew clean uploadArchives` to generate and upload the Samza
artifacts.
-* Login to the [repository web interface](https://repository.apache.org/) with
your Apache LDAP
-credentials, "close" the created repository and "release" it.
+
+# After the VOTE has passed
+
+If the VOTE has successfully passed on the release candidate, you can log in
to the [repository web interface](https://repository.apache.org) (same as
above) and "release" the org.apache.samza repository listed under "Staging
Repositories". This may take a minute or so.
+This will publish the samza release artifacts to the open source [maven
repository](https://repo1.maven.org/maven2)
Review comment:
Add period at end of sentence
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
