sborya commented on a change in pull request #984: Samza 2116: Making sink,
sendTo(table), sendTo(stream) non-terminal
URL: https://github.com/apache/samza/pull/984#discussion_r271996335
##########
File path:
samza-core/src/main/java/org/apache/samza/operators/impl/OutputOperatorImpl.java
##########
@@ -66,15 +66,15 @@ protected void handleInit(Context context) {
}
collector.send(new OutgoingMessageEnvelope(systemStream, null, key,
value));
- return CompletableFuture.completedFuture(Collections.emptyList());
+ return CompletableFuture.completedFuture(new
ArrayList<M>(Arrays.asList(message)));
Review comment:
do we need new Array here? You can just use ImmutableList
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
