weisong44 commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r272238645
##########
File path:
samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java
##########
@@ -135,6 +137,7 @@ public RemoteTableDescriptor(String tableId) {
Preconditions.checkNotNull(readFn, "null read function");
Preconditions.checkNotNull(retryPolicy, "null retry policy");
this.readRetryPolicy = retryPolicy;
+ this.readRetryPolicy.setTableId(String.format("%s.%s", tableId,
READ_RETRY_POLICY));
Review comment:
What happens when someone is reusing the same instance, would tableId be
overwritten? Can we add a check to avoid this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
