+ 1 (binding) Verified the signatures, built and ran the integration tests. All passed. There is one flaky test failure during running check-all.sh:
org.apache.samza.table.batching.TestBatchProcessor$TestBatchTriggered.testBatchOperationTriggeredByBatchSize FAILED java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.apache.samza.table.batching.TestBatchProcessor$TestBatchTriggered.testBatchOperationTriggeredByBatchSize(TestBatchProcessor.java:122) This shouldn't block the release as the test is flaky. We should either fix or disable this test for the future releases. Create ticket to track: https://issues.apache.org/jira/browse/SAMZA-2411 Thanks, Xinyu On Sun, Dec 1, 2019 at 6:20 PM Yi Pan <nickpa...@gmail.com> wrote: > +1 (binding), verified the signature, built and local integration tests > passed. > > Thanks! > > -Yi > > On Wed, Nov 27, 2019 at 2:49 PM Hai Lu <lhai...@apache.org> wrote: > > > Hi, > > > > This is a call for a vote on a release of Apache Samza 1.3.0. Thanks to > > everyone who has contributed to this release. > > > > The release candidate can be downloaded from here: > > http://home.apache.org/~lhaiesp/samza-1.3.0-rc2/ > > > > The release candidate is signed with pgp key 0x07678C76, which can be > found > > here: > > > > > https://keyserver.ubuntu.com/pks/lookup?search=0x07678C76&fingerprint=on&op=index > > or to directly see the public key here: > > > > > https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x1513eaedf69d7ca77ff283b534ea3ca507678c76 > > > > The git tag is release-1.3.0-rc2 and signed with the same pgp key above: > > > > > https://gitbox.apache.org/repos/asf?p=samza.git;a=commit;h=573ef951dd9d96d9d547db86bbc8023557714f47 > > > > Test binaries have been published to Maven's staging repository, and are > > available here: > > https://repository.apache.org/content/repositories/orgapachesamza-1073 > > > > The vote will be open for 171 hours (ending at 6:00 PM PST Wednesday, > > 12/4/2019). > > > > Please download the release candidate, check the hashes/signature, build > it > > and test it, and then please vote: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > I ran check-all.sh and integration tests (both YARN and standalone). > > > > +1 (non-binding) from my side. > > > > Thanks, > > Hai > > >
