(+1) binding, Downloaded the src tarball, run check-all.sh and passed all tests.
One thing noticed: there are configurations for your personal keys used for publishing the jars checked in gradle.properties. I don't think that we need to include that in the published src tarball. Otherwise, lgtm. Thanks a lot! -Yi On Wed, Dec 21, 2022 at 4:40 PM Xinyu Liu <xinyuliu...@gmail.com> wrote: > +1 (binding). > > Verified the md5 and sha1 checksums. Run check-all.sh on linux and the > build/tests all passed. Please also generate the sha256 checksums for the > release artifacts, according to Apache's requirements for open source > releases. > > Thanks, > Xinyu > > On Wed, Dec 21, 2022 at 9:47 AM Ajo Thomas <ajo.thoma...@gmail.com> wrote: > > > Hey All, > > > > This is a call for a vote on the release of *Apache Samza 1.8.0.* > > Thanks to everyone who contributed to this release. > > > > The release candidate can be downloaded from here: > > https://home.apache.org/~ajothomas/samza-1.8.0-rc0/ > > The release candidate is signed with pgp key *1A4639DA*, which is > included > > in the repository's KEYS file: > > https://git-wip-us.apache.org/repos/asf?p=samza.git;a=blob_plain;f=KEYS > > and > > can also be found on keyservers: > > > > > https://keyserver.ubuntu.com/pks/lookup?search=ajothomas%40apache.org&fingerprint=on&op=index > > < > > > https://keyserver.ubuntu.com/pks/lookup?search=ajothomas%40apache.org&fingerprint=on&op=index > > > > > > > The git tag is *release-1.8.0-rc0* and signed with the same pgp key: > > > > > https://gitbox.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.8.0-rc0 > > < > > > https://gitbox.apache.org/repos/asf?p=samza.git;a=tag;h=refs/tags/release-1.8.0-rc0 > > > > > > > Test binaries have been published to Maven's staging repository, and are > > available here: > > URL: https://repository.apache.org/#stagingRepositories > > <https://repository.apache.org/#stagingRepositories> > > Repository: orgapachesamza-1095 (org.apache.samza) > > > > Please download the release candidate, check the hashes/signature, build > it > > and test it, and then please vote: > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Please note that check-all.sh was run and integration tests *were not > *run > > as there are some issues with the legacy zopkio library used for > > integration testing. However, most of the key features being released as > a > > part of this release have been tested and are currently used in many of > our > > production jobs at LinkedIn. hadoop/yarn3 changes have been tested with > > https://github.com/apache/samza-hello-samza which brings up yarn 3, > > zookeeper and kafka clusters locally for testing. > > > > Thanks, > > Ajo > > >