> On Aug. 28, 2013, 8:42 p.m., Sriram Subramanian wrote: > > I am confused how the RoundRobin implementation is different from a FIFO > > implementation. Does this depend on an implementation detail outside it?
Hey Sriram, Yea, it depends on an outside detail, which is that update() will be called at most once per-system/stream/partition combination. This means that if you're given a message for kafka.mystream partition 7, you won't get another message from that SSP until you've returned the last one given to you (as a return value in the choose method). This behavior means that queueing messages at the end of the queue should result in a round-robin behavior, I think. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13725/#review25686 ----------------------------------------------------------- On Aug. 28, 2013, 6:23 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13725/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 6:23 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > adding docs for message chooser. swiching round robin chooser back to a queue. > > > missed license in message chooser factory > > > add apache licensing > > > samza container was using message chooser, not message chooser factory. fixed. > > > add stream chooser test. update stream chooser to invert priority due to bug. > > > add round robin test. fix compile error in round robin chooser. > > > add priority chooser test. fix bug in priority chooser that was reversing > ordering. > > > adding stream chooser. adding message chooser factory. > > > adding priority chooser. moving default chooser to round robin chooser. > adding config for chooser > > > Diffs > ----- > > docs/learn/documentation/0.7.0/container/streams.md > e755789407b294e02b399e71ba684c1d6dc314c6 > samza-api/src/main/java/org/apache/samza/system/MessageChooser.java > 306b2902303c72f3d7a3eb313f55d7e88d21e00d > samza-api/src/main/java/org/apache/samza/system/MessageChooserFactory.java > PRE-CREATION > samza-api/src/main/java/org/apache/samza/system/PriorityChooser.java > PRE-CREATION > samza-api/src/test/java/org/apache/samza/system/TestPriorityChooser.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/StreamChooserConfig.scala > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala > 0c742d83c2f60d2448a79376677713a1ff0b11ec > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 2d2efdd14c7680c29aad5f2a98349e2fc57cf9fe > samza-core/src/main/scala/org/apache/samza/system/DefaultChooser.scala > 5a72e7a3bfba0f06a5a98c6ba26865800d7780b9 > samza-core/src/main/scala/org/apache/samza/system/StreamChooser.scala > PRE-CREATION > > samza-core/src/test/scala/org/apache/samza/system/TestRoundRobinChooser.scala > PRE-CREATION > samza-core/src/test/scala/org/apache/samza/system/TestStreamChooser.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/13725/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
