-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13871/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 5:16 p.m.)


Review request for samza.


Repository: samza


Description (updated)
-------

tweak kv test to trigger NPE when test is run with Scala 2.8.1. Validate that 
patch fixes the bug. Add brackets in if else in cached store for style.


don't use remove() on head in cachedstore's double linked list because of 
https://issues.scala-lang.org/browse/SI-3970


Diffs (updated)
-----

  samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala 
0eed8fa6769436a7a073fd3d02dac74b87e7f305 
  samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala 
5f9d66cd640bd3f9b4cb669be429ad1545b28b0a 

Diff: https://reviews.apache.org/r/13871/diff/


Testing
-------


Thanks,

Chris Riccomini

Reply via email to