-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13969/#review26003
-----------------------------------------------------------



build.gradle
<https://reviews.apache.org/r/13969/#comment50751>

    Does this also include lib/*.jar? If memory serve correct, I thought you 
were trying to get a test tarball that had bin/*.sh and lib/*.jar.



samza-test/src/main/java/org/apache/samza/test/integration/join/EpochPartitioner.java
<https://reviews.apache.org/r/13969/#comment50758>

    Is this required? It seems like Checker is just sending strings, and I 
can't find anywhere else that the partitioner is used.



samza-test/src/main/resources/hello-stateful-world.samza
<https://reviews.apache.org/r/13969/#comment50756>

    namespace should be org.apache. for both factorie, and task.class.



samza-test/src/main/resources/perf/counter.samza
<https://reviews.apache.org/r/13969/#comment50757>

    org.apache for classes and factories.


- Chris Riccomini


On Sept. 4, 2013, 8:27 p.m., Jay Kreps wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13969/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 8:27 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-14
>     https://issues.apache.org/jira/browse/SAMZA-14
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Misc fixes for the QA jobs.
> 
> 
> Diffs
> -----
> 
>   build.gradle 4c4e99c 
>   docs/startup/hello-samza/0.7.0/index.md f561c95 
>   
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
>  e35227f 
>   samza-test/java.hprof.txt c5693d2 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/SimpleStatefulTask.java
>  973b0ba 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/StatePerfTestTask.java
>  873de74 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/join/Checker.java 
> 22f5e87 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/join/Emitter.java 
> 2989ca7 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/join/EpochPartitioner.java
>  d11d300 
>   samza-test/src/main/java/org/apache/samza/test/integration/join/Joiner.java 
> ca8fed4 
>   
> samza-test/src/main/java/org/apache/samza/test/integration/join/Watcher.java 
> fac4ee1 
>   samza-test/src/main/python/ghostface_killah.py PRE-CREATION 
>   samza-test/src/main/resources/common.properties 971a219 
>   samza-test/src/main/resources/hello-stateful-world.samsa 84325d0 
>   samza-test/src/main/resources/hello-stateful-world.samza PRE-CREATION 
>   samza-test/src/main/resources/join/README PRE-CREATION 
>   samza-test/src/main/resources/join/checker.samsa e41ffa0 
>   samza-test/src/main/resources/join/checker.samza PRE-CREATION 
>   samza-test/src/main/resources/join/emitter.samsa 140d13d 
>   samza-test/src/main/resources/join/emitter.samza PRE-CREATION 
>   samza-test/src/main/resources/join/joiner.samsa 27655d8 
>   samza-test/src/main/resources/join/joiner.samza PRE-CREATION 
>   samza-test/src/main/resources/join/reset.sh PRE-CREATION 
>   samza-test/src/main/resources/join/watcher.samsa a4cc761 
>   samza-test/src/main/resources/join/watcher.samza PRE-CREATION 
>   samza-test/src/main/resources/perf/counter.samsa cf06c9e 
>   samza-test/src/main/resources/perf/counter.samza PRE-CREATION 
>   
> samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala
>  7d4e20a 
> 
> Diff: https://reviews.apache.org/r/13969/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Kreps
> 
>

Reply via email to