-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13920/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 3:03 a.m.)
Review request for samza.
Bugs: SAMZA-25
https://issues.apache.org/jira/browse/SAMZA-25
Repository: samza
Description (updated)
-------
update samza yarn am metrics to match style of other metrics.
make jvm metrics use metrics helper, and use new style of metrics names
add licenses to metrics helper.
Merge branch 'SAMZA-25' of github.com:criccomini/incubator-samza into SAMZA-25
fixing infinite loop in metrics
use flushes and sends in system producers.
fix scala 2.8.1 issues
add kv store metrics.
add serialized store metrics.
add leveldb metrics.
adding metrics to logged store.
add caching store metrics. add a prefix for metrics helper.
adding broker proxy and kafka system consumer metrics. make all tests pass.
add kafka system consumer metrics.
switching kafka consumer to partially use new metrics pattern.
fix build errir in consumers/producers metrics. need map for counters so we can
increment them.
git status
add initial kafka system producer. remove source from metrics because it's not
required anywhere except in task instance and samza container, which already
know their sources.
add consumer metrics. rename dynamic metrics name to have variables first so
they are all grouped by variable name.
add system producers metrics
adding logging to system producers
make counter and gauges injectable so we don't have to constantly set gauge
values. set offset gauges in task instance using new method.
Merge branch 'SAMZA-25' of github.com:criccomini/incubator-samza into SAMZA-25
adding task instance metrics.
remove println in metrics helper test
initial pass at container metrics. trying to nail down style.
Diffs (updated)
-----
build.gradle 4c4e99c1196d0dc4a56d629ec1800196fb30c63f
samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java
a4563c439ab89a1aeb8ff2ada48eb31fff548ffa
samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java
c071c475230a6d62e2d233e82982e2f73ccc372d
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
2d2efdd14c7680c29aad5f2a98349e2fc57cf9fe
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala
81cf356db0961701343c0b143f32af6812857c35
samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala
c61994d112f63f54e4ff24aa03d078b2b04138ae
samza-core/src/main/scala/org/apache/samza/container/TaskInstanceMetrics.scala
07d72c736e554eb7828a7004f3dc3225449e708f
samza-core/src/main/scala/org/apache/samza/metrics/JvmMetrics.scala
164a2ee6eca3b049965809ae6717e3531e224639
samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala
PRE-CREATION
samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala
fc0bd3877309d58751e9af88049d41aef46e9dae
samza-core/src/main/scala/org/apache/samza/system/SystemConsumers.scala
b18f0cc5a21088a58db1c26ff43bba06dd3165ac
samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala
PRE-CREATION
samza-core/src/main/scala/org/apache/samza/system/SystemProducers.scala
099c0bfba016431065c3bf4de68ca13175e54516
samza-core/src/main/scala/org/apache/samza/system/SystemProducersMetrics.scala
PRE-CREATION
samza-core/src/test/scala/org/apache/samza/metrics/TestMetricsHelper.scala
PRE-CREATION
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala
214de925a38d2e9ee44d237be241595c24a6404d
samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxyMetrics.scala
bdd91da92dad526a7cfc836b9bb8adc4d79c0eb0
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumer.scala
7970ffcfd7851cb536561ae752de2cf82e512906
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala
PRE-CREATION
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala
fe96dd875cef5151a5b750327c9047d027e28c44
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala
e35227fa2b646e847dfda6a7c2ab7f82d3821ff3
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducerMetrics.scala
PRE-CREATION
samza-kafka/src/main/scala/org/apache/samza/system/kafka/TopicAndPartitionMetrics.scala
75fc0223cde2bb42c9b9499b1b108208bb61db65
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala
947f5a7feff8dfa426e86919679792a7b3e53a6a
samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestKafkaSystemProducer.scala
a21e3bf9a4667d676c7773284922e69e9da2d9b7
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala
bd479b6ab895ffa2b6077cbd6206f20f1453a82f
samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStoreMetrics.scala
PRE-CREATION
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala
92eee38524e25bb9f8383bd3fbf649f73de7180e
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala
dbdefa0b8a86adb905bd5bd4fe33d4da8eac23ba
samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineMetrics.scala
PRE-CREATION
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStore.scala
ac6da252f8b50528f24ecf9500fc02bfac688154
samza-kv/src/main/scala/org/apache/samza/storage/kv/LevelDbKeyValueStoreMetrics.scala
PRE-CREATION
samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStore.scala
a1b547d02138dc0f2b9f680ecd8fd24db21ba918
samza-kv/src/main/scala/org/apache/samza/storage/kv/LoggedStoreMetrics.scala
PRE-CREATION
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
75fd414d157d2390235cc4066bb01a13b8e16d9f
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStoreMetrics.scala
PRE-CREATION
samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterMetrics.scala
4f6edfb929cc091c7902f653b28270d278869df6
Diff: https://reviews.apache.org/r/13920/diff/
Testing
-------
Thanks,
Chris Riccomini
