----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16033/#review29818 -----------------------------------------------------------
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala <https://reviews.apache.org/r/16033/#comment57299> Return type would be nice for readability. samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala <https://reviews.apache.org/r/16033/#comment57300> Might as well make this a generic utility and throw it in a test utils class def expect[T](exception: Class[T])(block: => Unit) This will let you do expect(classOf[MyException]) { // some code goes here } - Jay Kreps On Dec. 5, 2013, 2:39 a.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16033/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 2:39 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > failing on null writes in all serde methods. > > > Diffs > ----- > > > samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala > 53a5cbeddcee61c05beb9c858eb81d11a1cd5d93 > > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > 2e5f6a3fe8db96fcbb409619b4890ac5359f6d17 > > Diff: https://reviews.apache.org/r/16033/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
