----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16159/#review30138 -----------------------------------------------------------
Ship it! Looks good. Might be nice to move the notNull method into Utils, though. - Jay Kreps On Dec. 10, 2013, 6:47 p.m., Chris Riccomini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16159/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 6:47 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > create a null safe key value store, and remove all null checks from serde > store > > > create a test that exposes the bug. > > > Diffs > ----- > > > samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngineFactory.scala > d42f46ec59b70bbff5814862f3b86dab0195502e > > samza-kv/src/main/scala/org/apache/samza/storage/kv/NullSafeKeyValueStore.scala > PRE-CREATION > > samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala > c3bf4dcc37718ef57e4332e5daa9a6725b5b0739 > > samza-kv/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala > e8db3f2111f1bfa922b4014b828c41d0c61a7151 > > Diff: https://reviews.apache.org/r/16159/diff/ > > > Testing > ------- > > > Thanks, > > Chris Riccomini > >
