Hi Chris,

OK, I created SAMZA-125 for this. I know the HelloSamza code isn't in the 
Apache repo but visibility and all that.

Attached two patches, one to change the grid script itself as you described and 
also to add 'all' options to the install/start/stop commands.  And another 
patch with the requisite changes to the docs for the webpage.  The HS readme 
only points to the webpage.

Thanks
Garry

-----Original Message-----
From: Chris Riccomini [mailto:[email protected]] 
Sent: 08 January 2014 22:42
To: [email protected]
Subject: Re: Default behaviour of HelloSamza bin/grid script

Hey Garry,

Hmm, yeah that seems reasonable.

The bin/grid script actually does a full clean, and downloads and deploys ZK, 
Kafka, and YARN. Maybe we should update it so that bin/grid just prints the 
help screen, and switch the current default to be `bin/grid bootstrap` or 
something like that? We'd have to update the docs and README, as well, I think.

Cheers,
Chris

On 1/8/14 2:11 PM, "Garry Turkington" <[email protected]>
wrote:

>Hi all,
>
>Been playing with HelloSamza and using it to test Samza on a few hosts.
>It's a pretty cool way of bootstrapping things.
>
>Maybe no one else fat fingers this but a couple of times now I've ran 
>bin/grid without arguments and triggered the default behaviour which is 
>to remove the build dirs. And do a clean set-up from scratch. It may be 
>less surprising to have the no arg case check for the existence of the 
>build dir and bail, possibly referring to a new 'clean' option?
>
>Or maybe it's just me. :)
>
>Garry
>


-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 2014.0.4259 / Virus Database: 3658/6984 - Release Date: 01/07/14

Reply via email to