----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17705/#review33614 -----------------------------------------------------------
This looks good. Could you update MetricsSnapshotReporter and JvmMetrics to use the new naming method? Could you also update BrokerProxy's thread to use the constant from DaemonThreadFactory, as well? samza-core/src/main/scala/org/apache/samza/util/DaemonThreadFactory.scala <https://reviews.apache.org/r/17705/#comment63150> Prefer having a static constant defined in a DaemonThreadFactory object for thread prefix, and use constant prefix in unit test. - Chris Riccomini On Feb. 4, 2014, 12:33 p.m., Steven Yates wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17705/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 12:33 p.m.) > > > Review request for samza and Steven Yates. > > > Bugs: SAMZA-96 > https://issues.apache.org/jira/browse/SAMZA-96 > > > Repository: samza > > > Description > ------- > > Review request for SAMZA-96 > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/util/DaemonThreadFactory.scala > 04e67a2 > > samza-core/src/test/scala/org/apache/samza/util/TestDaemonThreadFactory.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/17705/diff/ > > > Testing > ------- > > Unit test TestDaemonThreadFactory.scala > > > Thanks, > > Steven Yates > >
